Fix Suggestion Provider for Crossref during autocompletion disable #10829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
reviewed
Jan 29, 2024
Siedlerchr
reviewed
Jan 29, 2024
src/main/java/org/jabref/gui/autocompleter/SuggestionProviders.java
Outdated
Show resolved
Hide resolved
|
Generally looks good, just remove the commented out code |
|
@Siedlerchr I have made all the changes you suggested please review those. Thanks for your suggestions. |
Siedlerchr
previously approved these changes
Jan 30, 2024
|
Can you please add a changelog entry? (I edit/push my changes to your fork) |
|
@Siedlerchr I will keep that in mind to open a new branch next time. |
Siedlerchr
approved these changes
Feb 1, 2024
|
The code is OK. However, the requirements at #8145 are a mess. I think, the preferences should be modified to be more user-friendly. Will file an issue in our melting pot. |
Siedlerchr
added a commit
that referenced
this pull request
Feb 3, 2024
* upstream/main: Update deployment-arm64.yml fix linebreak fix condition Update deployment-arm64.yml rename Update deployment-arm64.yml Switch to arm runner macos14 Update journal abbreviation lists (#10846) Fix Suggestion Provider for Crossref during autocompletion disable (#10829) Update CSL styles (#10844) Space before citations in Openoffice/Libreoffice integration (#10843)
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8145
Fixed the initial issue when autocompletion was disabled, the crossref field was not populating the suggestions.
Now the CrossRef field is populating the suggestions even if AutoCompletion(File > Preferences > Autocompletion) is disabled
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)